src: check for --prof in ParseArgs #2533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all of the cli arguments are parsed and then we loop through the v8 arguments again. This patch removes the need for the additional loop as we can check if the argument is --prof during the initial ParseArgs.
evanlucas
added
the
c++
|
I guess I don't really see the point. The number of comparisons stays the same, right? |
|
The number of comparisons doesn't change, but it prevents the additional loop through v8_argv. I trust your opinion though, so if you think it is worthless, I can close :] |
|
I suspect it's basically a wash and possibly a pico-deoptimization. The loop counter probably lives in a register but |
|
works for me |
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all of the cli arguments are parsed and then we loop
through the v8 arguments again. This patch removes the need for the
additional loop as we can check if the argument is --prof during the
initial ParseArgs.